Pull request overview

Adds a best-effort cleanup path for temporary converted volumes when VMware→KVM import fails, and refactors KVM conversion wrappers to share common helper logic.

Changes:

• Trigger cleanup of temporary converted disks on import failures/timeouts.
• Introduce CleanupConvertedInstanceDisksCommand and a corresponding KVM resource wrapper to delete leftover conversion artifacts.
• Refactor LibvirtImportConvertedInstanceCommandWrapper to reuse a new shared LibvirtBaseConvertCommandWrapper.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

code LGTM. @nvazquez please check if we can add some unit tests here.

LGTM

Executed the full test plan for FR307: VMWare-2-KVM part II - Cleanup after failure - 19/19 test cases Pass (100%).

Summary:
Testing covered cleanup of temporary artifacts (disks and XML descriptors) after failed VMware-to-KVM imports: temporary locations on the primary pool and NFS secondary storage, XML handling (present / absent / corrupt with fallback to prefix listing), forceConvertToPool positive and negative paths, mid-move multi-disk failure (customer repro), destination-pool orphan check, and correct cleanup scoping (concurrent imports and the convert-stage boundary remain untouched). Negative scenarios confirmed no crashes when there is nothing to clean or when cleanup itself fails, with the original error preserved. Failed conversions are correctly reflected in the UI and in listImportVmTasks, and the successful import regression passed with temporary artifacts fully cleaned.

Executed test cases:

• Concurrent imports cleanup scoped to failed prefix only
• Import fails after temporary disks already cleaned nothing to clean no crash (negative)
• Convert host equals import host VDDK same host cleanup works
• Import VM tasks UI reflects failed conversion
• listImportVmTasks shows Failed record on pool selection failure
• Convert-stage failure not cleaned scope boundary
• forceConvertToPool success no erroneous cleanup (positive)
• forceConvertToPool import failure cleans pool disks (negative)
• Successful import regression temporary fully cleaned (positive)
• Temporary location primary pool cleaned
• Temporary location NFS secondary cleaned (positive)
• Destination-pool orphan check after mid-move failure (negative)
• Mid-move multi-disk failure temporary fully cleaned customer repro
• Cleanup with corrupt XML falls back to prefix listing (CS-3416)
• Cleanup with XML absent removes disks skips XML
• Cleanup with XML present removes disks and XML (positive)
• Import failure agent unavailable cleans temporary disks
• Cleanup failure preserves original error and does not crash (negative)
• Import failure bad result cleans temporary disks (positive)